This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Remove start and end values from JSX tokens (fixes #341) #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
JamesHenry
force-pushed
the
jsx-start-end-fix
branch
from
23f4b2e to
b9fc560
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as the bug fix in the name, this also includes an update to a fixture which contained invalid JSX. No parser (including espree) other than TypeScript was even able to parse the source so I have updated to be valid and updated its snapshot accordingly.
After doing that, I was able to successfully add it to the AST alignment tests.