This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Breaking: Remove TypeAnnotation wrapper from constraint #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
JamesHenry
force-pushed
the
type-parameters-convergence
branch
from
785ad11 to
f004236
Compare
|
Thanks for the pull request, @JamesHenry! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #324, I'll rebase it after that one gets merged.
This PR addresses the difference outlined here https://github.com/JamesHenry/tsep-babylon-test/issues/10, removing the TypeAnnotation wrapper around the
constraintof the type parameter.I'm on a roll of discovering issues with my snapshot testing setup - we are catching thrown errors and writing them to error snapshots, but we were missing extra handling to make sure we fail the test on an unrecognised AST_NODE_TYPE, so I have addressed that by rethrowing.