New: Support TypeScript 2.4 (fixes #321) #322
Conversation
|
LGTM |
|
LGTM |
|
LGTM |
|
Added a test for |
|
LGTM |
|
@azz I have created a branch called |
|
LGTM |
|
Done |
package.json
Outdated
| @@ -26,7 +26,7 @@ | |||
| "npm-license": "0.3.3", | |||
| "shelljs": "0.7.7", | |||
| "shelljs-nodecli": "0.1.1", | |||
| "typescript": "~2.3.2" | |||
| "typescript": "~2.4 || ~2.3.2" | |||
There was a problem hiding this comment.
Thanks, as per my comments on the issue I feel this should still just be one version for now. We can potentially look to change this philosophy before ts-2.4 is merged into master
README.md
Outdated
| @@ -8,7 +8,7 @@ A parser that converts TypeScript into an [ESTree](https://github.com/estree/est | |||
|
|
|||
| We will always endeavor to support the latest stable version of TypeScript. | |||
|
|
|||
| The version of TypeScript currently supported by this parser is `~2.3.2`. This is reflected in the `devDependency` requirement within the package.json file, and it is what the tests will be run against. We have an open `peerDependency` requirement in order to allow for experimentation on newer/beta versions of TypeScript. | |||
| The version of TypeScript currently supported by this parser is `~2.3.2 || ~2.4`. This is reflected in the `devDependency` requirement within the package.json file, and it is what the tests will be run against. We have an open `peerDependency` requirement in order to allow for experimentation on newer/beta versions of TypeScript. | |||
|
I'm ok with having a range of versions but it is often not possible to do so. This release might be one where no breaking changes occur in the AST and its possible to have a version range. I like the idea of having a separate branch for now just to ensure no surprises come up. |
|
LGTM |
|
Thanks, @azz! |
Makes sense to keep support for 2.3 until 2.4 is stable upstream.
Fixes #321.