This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Use TSNullKeyword for null type instead of Literal #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. Developing this in jest watch mode with the snapshot diff was a joy 😄 |
|
I think this needs a more holistic solution, already found a case that this change won't catch... |
|
Updated with a much better fix, now ready for review |
soda0289
approved these changes
Jun 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went for the simplest possible solution for now to resolve https://github.com/JamesHenry/tsep-babylon-test/issues/16.
Another awkward one in terms of Breaking vs Fix, but Fix feels ok here.