This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Add more tests for destructuring and spread (fixes #306) #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
soda0289
commented
Jun 2, 2017
soda0289
commented
- Copied over a lot more tests from espree for destructuering and spread
- Fixed issues with RestElement and SpreadElement
- Fixed issues with ArrayPattern and ArrayExpression
- Fixed issue with array RestElement in function parameter binding
- Updated findFirstMatchingChild node util to recursively search for children
|
LGTM |
|
Would it be possible for you to make a branch with both this and #303 so that I can use it? I'd love to do a 1.4.1 release for prettier and would love to get both those PR in :) Thanks! |
|
Nevermind, did it here: https://github.com/vjeux/typescript-eslint-parser/commits/prettier-fixes. Can't wait for those two to land :) Thanks for fixing them so quickly! |
vjeux
added a commit
to vjeux/prettier
that referenced
this pull request
Jun 2, 2017
This applies eslint/typescript-eslint-parser#308 and eslint/typescript-eslint-parser#303 to fix issues on prettier. Fixes prettier#1870
vjeux
added a commit
to vjeux/prettier
that referenced
this pull request
Jun 2, 2017
This applies eslint/typescript-eslint-parser#308 and eslint/typescript-eslint-parser#303 to fix issues on prettier. Fixes prettier#1870
vjeux
added a commit
to prettier/prettier
that referenced
this pull request
Jun 2, 2017
This applies eslint/typescript-eslint-parser#308 and eslint/typescript-eslint-parser#303 to fix issues on prettier. Fixes #1870
This was referenced Jun 2, 2017
JamesHenry
approved these changes
Jun 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.