This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Chore: Replace mocha (istanbul, chai, leche) with Jest #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soda0289
approved these changes
May 28, 2017
|
Should we merge this in for the next release? |
|
Shouldn't make any difference either way, it's a development-only concern. I'm happy to wait until the next batch |
This has been invaluable for prettier. I honestly don't think I would have finished it without snapshot testing. I highly recommend :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exactly matches our current usage of Mocha (+ istanbul, chai and leche) but using Jest.
There is no change in how assertions are being made, nor how coverage is reported (Jest can provide it out of the box).
I have continued to use the original Makefile for the primary
npm testcommand so as to minimise the changes in this initial PR, but added an additionalnpm run jestcommand (for development purposes), because Jest gives really nice output for failures/diffs and you lose the colour from that when executing it via another tool (Makefile nodeCLI).Jest's watch mode is also excellent for development, so you now easily run that using
npm run jest -- --watch.I plan to explore formatted snapshot testing with Jest in a follow up PR, because it will provide an effortless way for us to deterministically update test cases when we make breaking changes (which will we be doing a lot more of to align with the Babylon work)