Breaking: Decorator ESTree compliance, always convert (fixes #250) #293
Conversation
JamesHenry
force-pushed
the
decorator-fix
branch
2 times, most recently
from
045afc5 to
2cadbe4
Compare
|
LGTM |
JamesHenry
changed the title
|
I have updated the PR to both fix our ESTree compliance, and ensure conversion during Importantly, I also took this opportunity to "fix" It will now use the same assertion logic as the tests, and only perform a write to an existing result file if the assert fails. |
| function outputResult(result, testResultFilename) { | ||
| shelljs.echo("module.exports = " + JSON.stringify(result, null, " ") + ";").to(testResultFilename); | ||
| shelljs.echo(`module.exports = ${JSON.stringify(result, null, " ")};`).to(testResultFilename); |
There was a problem hiding this comment.
I thought about using this tool but sometimes it will generate JSON objects that are inconsistent or change for no reason. By adding the deep equal assertion it does prevent updating every file but maybe we should make the stringifyed JSON output consistent. We can use a tool like this: https://github.com/substack/json-stable-stringify to sort the output keys. This could be done later just a thought.
|
LGTM |
|
Rebased this, will merge once it has built |
(convertDecorators had to be moved purely to comply with "no use before define" rule)