This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Set node type to ExperimentalRestProperty (fixes #276) #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
So, this is not yet ready for review? |
|
LGTM |
|
@JamesHenry should be good to review. I copied the object rest spread tests from espree and made some changes to allow all the tests to pass. |
JamesHenry
approved these changes
May 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not using the correct node type when an object spread was used in a function parameter. This commit checks for the dotDotDot property can creates an
ExperimentalRestPropertif set.I don't think typescript supports using an initializer or property name so I do not convert these properties.Edit: TypeScript does support inital value and renaming of property. Will update the PR and tests