This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Add support async iterators #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Requisite PR merged, just let me know whenever this is ready to be reviewed |
soda0289
force-pushed
the
add-support-async-iterators
branch
from
d30cc2f to
401cd66
Compare
|
Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
soda0289
force-pushed
the
add-support-async-iterators
branch
from
401cd66 to
69a0ffa
Compare
|
LGTM |
|
@JamesHenry should be good to review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit depends upon #237. Since that PR adds tests for async generators and allows experimental ecma-features tests to run.
https://github.com/estree/estree/blob/master/experimental/async-iteration.md