This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Calculate range correctly when class is exported (fixes #152) #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The range of a class body should be from the opening brace to the closing brace. To find the opening brace the ast converter parses over modifiers of the class declaration and assumes it is the last token after the last node modifier. This assumption is not always true when the class is exported. This commit ensures we only skip over modifiers which are after the class name or heritage clause.
|
LGTM |
soda0289
added a commit
to soda0289/typescript-eslint-parser
that referenced
this pull request
Feb 7, 2017
…) (eslint#153) The range of a class body should be from the opening brace to the closing brace. To find the opening brace the ast converter parses over modifiers of the class declaration and assumes it is the last token after the last node modifier. This assumption is not always true when the class is exported. This commit ensures we only skip over modifiers which are after the class name or heritage clause.
soda0289
added a commit
to soda0289/typescript-eslint-parser
that referenced
this pull request
Feb 7, 2017
…slint#152) When a class with a generic definition is exported we must take the type parameters into account when finding the opening brace. This continues the fix of pull request eslint#153 and handles the case of exporting a class with generics. We now find the last type parameter and use the succeeding token as the opening brace.
soda0289
added a commit
to soda0289/typescript-eslint-parser
that referenced
this pull request
Feb 7, 2017
…slint#152) When a class with a generic definition is exported we must take the type parameters into account when finding the opening brace. This continues the fix of pull request eslint#153 and handles the case of exporting a class with generics. We now find the last type parameter and use the succeeding token as the opening brace.
soda0289
added a commit
to soda0289/typescript-eslint-parser
that referenced
this pull request
Feb 7, 2017
…nt#152) When a class with a generic definition is exported we must take the type parameters into account when finding the opening brace. This continues the fix of pull request eslint#153 and handles the case of exporting a class with generics. We now find the last type parameter and use the succeeding token as the opening brace.
soda0289
added a commit
to soda0289/typescript-eslint-parser
that referenced
this pull request
Feb 7, 2017
…nt#152) When a class with a generic definition is exported we must take the type parameters into account when finding the opening brace. This continues the fix of pull request eslint#153 and handles the case of exporting a class with generics. We now find the last type parameter and use the succeeding token as the opening brace.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The range of a class body should be from the opening brace to the
closing brace. To find the opening brace the ast converter parses over
modifiers of the class declaration and assumes it is the last token
after the last node modifier. This assumption is not always true when the
class is exported. This commit ensures we only skip over modifiers
which are after the class name or heritage clause.