This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Calculate constructor method range using node.parameters.pos (fixes #139) #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
…int#139) The class constructor method node range can be calculated using the node.parameters.pos variable instead of using result.range and offset. This fixes issues with the space-before-function-paren rule in eslint.
soda0289
force-pushed
the
fix-constructor-with-space
branch
from
43609bf to
86913c7
Compare
|
LGTM |
nzakas
approved these changes
Jan 13, 2017
|
Awesome, thanks! |
soda0289
added a commit
to soda0289/typescript-eslint-parser
that referenced
this pull request
Feb 1, 2017
soda0289
added a commit
to soda0289/typescript-eslint-parser
that referenced
this pull request
Feb 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class constructor method node range can be calculated using the
node.parameters.pos variable instead of using result.range and offset.
This fixes issues with the space-before-function-paren rule in eslint.