Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fix async function and variable declartions #137

Closed
wants to merge 6 commits into from

Conversation

soda0289
Copy link
Member

@soda0289 soda0289 commented Jan 9, 2017

Async functions mark all variables as constants since the flags are not being read correctly. This patch uses the builtin typescript utilities functions to determine the variable declaration type.

Some tests are broken and I will need to add tests for this new case. Just looking for feedback.

@jsf-clabot
Copy link

jsf-clabot commented Jan 9, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ soda0289
✅ JamesHenry
✅ flying-sheep
❌ ESLint Jenkins


ESLint Jenkins seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@eslintbot
Copy link

Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@eslintbot
Copy link

Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

This fixes issue an where async function will mark all
variable declarations as constant.
@eslintbot
Copy link

Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@soda0289
Copy link
Member Author

Replaced with pull request #138

@soda0289 soda0289 closed this Jan 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants