Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fix: export type alias ExportNamedDeclaration node generation (fixes #134) #135

Merged
merged 3 commits into from
Jan 10, 2017

Conversation

weirdpattern
Copy link
Contributor

This includes:

  • Fix to ast-converter, addition of fixExports function call in SyntaxKind.TypeAliasDeclaration case statement.
  • Corresponding tests

@eslintbot
Copy link

Thanks for the pull request, @weirdpattern! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@weirdpattern weirdpattern changed the title Fix: export type alias ExportNamedDeclaration node generation (fix #134) Fix: export type alias ExportNamedDeclaration node generation (fixes #134) Jan 5, 2017
@eslintbot
Copy link

Thanks for the pull request, @weirdpattern! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JamesHenry JamesHenry merged commit 918190d into eslint:master Jan 10, 2017
@weirdpattern weirdpattern deleted the export-literal-types branch January 10, 2017 13:39
soda0289 pushed a commit to soda0289/typescript-eslint-parser that referenced this pull request Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants