Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fix: Changed --save to --save-dev in readme #132

Merged
merged 1 commit into from
Jan 2, 2017

Conversation

amilajack
Copy link
Contributor

this probably fits most use-cases

@eslintbot
Copy link

Thanks for the pull request, @amilajack! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@amilajack amilajack changed the title Changed --save to --save-dev in readme Fix: Changed --save to --save-dev in readme Jan 2, 2017
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesHenry JamesHenry merged commit dd03b2f into eslint:master Jan 2, 2017
@JamesHenry
Copy link
Member

JamesHenry commented Jan 2, 2017

Please note for further contributions that your commit message should have been Docs: Changed --save to --save-dev in readme. I amended this when merging.

Please be sure to read http://eslint.org/docs/developer-guide/contributing/pull-requests

@amilajack amilajack deleted the patch-1 branch January 2, 2017 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants