Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fix: Add loc and range data to generated VariableDeclarator node #100

Merged
merged 1 commit into from
Sep 23, 2016

Conversation

JamesHenry
Copy link
Member

I am really sorry this has now taken a 3rd PR to get right.

This adds loc and range data for the generated VariableDeclarator - core indent is currently throwing an error because loc is undefined

@eslintbot
Copy link

Thanks for the pull request, @JamesHenry! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@nzakas
Copy link
Member

nzakas commented Sep 23, 2016

Not a problem, that's why we're still in experimental mode. :)

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit eb1ad9b into master Sep 23, 2016
@JamesHenry JamesHenry deleted the type-as-var-fix branch October 13, 2016 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants