Missing static from TSParameterProperty

[vjeux]

What version of typescript-eslint-parser are you using?
b7220fd

What code were you trying to parse?

// ../TypeScript/tests/cases/compiler/constructorArgsErrors1.ts
class foo {
  constructor(static a: number) {}
}

What did you expect to happen?
Have static: true inside of TSParameterProperty

What happened?

Doesn't have it

{
  "type": "TSParameterProperty",
  "range": [
    30,
    46
  ],
  "loc": {
    "start": {
      "line": 2,
      "column": 17
    },
    "end": {
      "line": 2,
      "column": 33
    }
  },
  "accessibility": null,
  "isReadonly": false,
  "parameter": {
    "type": "Identifier",
    "range": [
      37,
      38
    ],
    "loc": {
      "start": {
        "line": 2,
        "column": 24
      },
      "end": {
        "line": 2,
        "column": 25
      }
    },
    "name": "a",
    "typeAnnotation": {
      "type": "TypeAnnotation",
      "loc": {
        "start": {
          "line": 2,
          "column": 27
        },
        "end": {
          "line": 2,
          "column": 33
        }
      },
      "range": [
        40,
        46
      ],
      "typeAnnotation": {
        "type": "TSNumberKeyword",
        "range": [
          40,
          46
        ],
        "loc": {
          "start": {
            "line": 2,
            "column": 27
          },
          "end": {
            "line": 2,
            "column": 33
          }
        }
      }
    }
  },
  "decorators": []
}

[vjeux]

Actually, i'm not really sure what's going on here. The ast difference is:

../TypeScript/tests/cases/compiler/constructorArgsErrors1.ts
: ast(input) !== ast(prettier(input))
Index:
===================================================================
---
+++
@@ -18,15 +18,10 @@
               "params": [
                 {
-                  "type": "TSParameterProperty",
-                  "accessibility": null,
-                  "isReadonly": false,
-                  "parameter": {
-                    "type": "Identifier",
-                    "name": "a",
+                  "type": "Identifier",
+                  "name": "a",
+                  "typeAnnotation": {
+                    "type": "TypeAnnotation",
                     "typeAnnotation": {
-                      "type": "TypeAnnotation",
-                      "typeAnnotation": {
-                        "type": "TSNumberKeyword"
-                      }
+                      "type": "TSNumberKeyword"
                     }
                   },

I don't think that it's actually valid to have static there.

[soda0289]

Good catch thanks. Should be a simple fix, just need to check for static modifier.

Typescript does complain: 'static' modifier cannot appear on a parameter. But I think we should still generate a matching AST. We do something similar for abstract interface even thou it is invalid as well.

[vjeux]

constructor (export a: number) {

has the same issue fyi.