ImportDeclaration.parent is not expected to be a TSModuleDeclaration

[flying-sheep]

the rule import/newline-after-import accesses a ImportDeclaration’s parent, expecting it to have a body

that’s not true if you encounter a TSModuleDeclaration → TSModuleBlock → ImportDeclaration:

declare module 'postcss-modules' {
	import {Plugin} from 'postcss'
	...
}

a fix for this specific problem would be a visitor like TSModuleDeclaration(m) { m.body = m.statements }

[soda0289]

I have seen this one before. If I remember correctly it doesnt cuase a crash. But it expects that the parent is the Program node, which is true for es6. Not sure if we should update our produced ast nodes or fix the plugin. But in this case it might make sense to use the property body instead of statements. I think class nodes use body property can't remember which nodes, if any, use the statements property.

[flying-sheep]

it crashed for me:

const { parent } = node  // parent === { type: 'TSModuleBlock', statements: [...], ... }
const nodePosition = parent.body.indexOf(node)  // parent.body === undefined

[soda0289]

Do you want to submit a PR to rename statements property to body? I looked in the ESTree spec and they never use statements as a property only body. I think we should follow that same pattern.

[flying-sheep]

Done: #218