Some small tweaks, new tests and docs #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a couple of quick changes:
Accept
header to use it anymoreupdate
method was a bit misleading/unclear. Per this page:As a result, I've renamed it to
updateStatus
to try and prevent confusion.As for the tests:
In terms of documentation:
Thanks for your existing work on this, the existing code was nice to work with. Hopefully this can be pulled into knplabs/php-github-api soon.