Skip to content

fixing unique together validator for fields with source #7005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

fixing unique together validator for fields with source #7005

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
09d028d
fixing the source from where the name of the field should be taken
Oct 18, 2019
6d427b4
test case that is failing
Oct 22, 2019
0cc4624
choice of both field.source and field.field_name added
Oct 22, 2019
aa500b3
1.Revoked the previous change fixed the uniquetogether validator
Oct 24, 2019
e6ad108
update operation in uniquetogether validator is fixed
Oct 25, 2019
c87e53a
fixing for PUT requests
Oct 25, 2019
a3e5559
added proper tests for the readonly and writable fields with source t…
Oct 29, 2019
5902dac
fixing writable fields test by including field.field_name in place of…
Oct 29, 2019
e240a63
reverting changes for writable field fix
Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rest_framework/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ def _read_only_defaults(self):
default = field.get_default()
except SkipField:
continue
defaults[field.field_name] = default
defaults[field.source] = default

return defaults

Expand Down