Be slightly more careful to take the first paragraph #2110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous algorithm was easily fooled into emitting unbalanced tags, so the logic is tightened up with a more specific regex. Overall, this probably isn't doing the right thing. Consider making the synopsis more robust by using eg. Floki in production. Closes elixir-lang#2108 , sort of...
josevalim
reviewed
Apr 6, 2025
| Regex.run(~r|<p>((?:(?!</p>).)*?):*</p>|, doc) | ||
| |> case do | ||
| nil -> doc | ||
| [_, first_paragraph_text] -> "<p>" <> first_paragraph_text <> "</p>" | ||
| end |
There was a problem hiding this comment.
We are kind of assuming that it starts with <p>, so perhaps I would enforce that instead?
case String.trim_leading(doc) do
"<p>" <> _ = doc ->
doc =
case :binary.split(doc, "</p>") do
[left, _] -> String.trim_trailing(left, ":") <> "</p>"
[all] -> all
end
Regex.replace(~r|(<[^>]*) id="[^"]*"([^>]*>)|, doc, ~S"\1\2", [])
_ ->
nil
end
Alternatively we capture the synopsis over the AST instead of the rendered document. This would also make it easier to remove links and what not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous algorithm was easily fooled into emitting unbalanced tags, so the logic is tightened up with a more specific regex.
Overall, this probably isn't doing the right thing. Consider making the synopsis more robust by using eg. Floki in production.
Closes #2108 , sort of...