Create .exdoc file after warning about using an existing directory #1713
Conversation
|
Is this something we could add a test on? Do we test the warning is emitted? If so, can we test the warning is not emitted on the second run? thank you ❤️ |
|
I've added this check to the tests that I've added when implementing this feature, I think there's no reason to duplicate the entire test just to test this property. |
|
Not sure why this test failing, I've just ran the test suite locally 15 times in a row and it passed them all consistently 🤔 |
|
You are capturing output from other tests that are running concurrently. You may need to mark those cases as async: false (or move those particular tests to another module with async: false). |
|
@wojtekmach is there a better test structure we could use here? |
|
|
||
| assert ExUnit.CaptureIO.capture_io(:stderr, fn -> | ||
| generate_docs(tmp_dir) | ||
| end) =~ "" |
There was a problem hiding this comment.
any string would pass this assertion be we want to make sure we didn't print any warnings!
| end) =~ "" | |
| end) == "" |
There was a problem hiding this comment.
My bad here, forgot to change the operator
|
Thank you! |
Currently, if an user tries to set
--outputto a directory that already contains files, ex_doc will emit a warning about that and create the files anyway, but it never creates the.exdocfile, meaning every timemix docsis run on that directory it will display the same warnings.This pull requests calls the create callback after emitting the warning, so that in subsequent invocations no warnings will be emitted.