-
Notifications
You must be signed in to change notification settings - Fork 27
Add support for MySQL/MariaDB #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I ran the tests locally and they passed. Someone needs tot trigger the CI so I can fix potential CI issues. |
84b531b
to
3a328d3
Compare
Thanks for this PR @phihos! It looks great, I will take a deeper look later this week. Apparently GitHub Actions doesn't like the |
Hi, thanks for the feedback. I checked the health command and according to an official blogpost the command is correct. I also tried it myself and the script and its argument are accepted. I guess GH actions/docker does not like the single quotes very much. I replaced them with double quotes and added |
Fixed the formatting issue. Next run should at least go to the database tests. |
I forgot a line in the example test config which I put in my local test config. The tables should exist now. @crbelaus Can you trigger CI again? |
Sorry, I accidentally reverted the health-cmd fix. Should work again now. |
I also accidentally reverted the formatter fix from yesterday 🙈 |
Finally 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!! Thanks for this amazing contribution ❤️
Thank you for merging my PR. Now I do not have to maintain a fork for my use-case. Your code was already very well structured and implementation went smoothly. Looking forward to future releases :-) |
This PR adds support for the Exto adapter
Ecto.Adapters.MyXQL
.Closes #85.