report errors that originate from LiveComponents #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odarriba
reviewed
Aug 29, 2024
…t separated by process boundaries
odarriba
pushed a commit
that referenced
this pull request
Sep 1, 2024
As @odarriba and @numso discussed on #74 the current approach of adding LiveView event information to the process context may result in misleading information for certain errors. > For example, if the following happened: > > 1. mount the liveview > 2. handle_event("something", params, socket) in the liveview > 3. handle_info("something_else", socket) causing a re-render > 4. render -> exception occurs > > I think live_view.event and live_view.event_params would still be in the error context when the exception was reported. They would have been assigned to context in step 2. But by step 4, that data could be irrelevant. Am I understanding that right? This pull request adds the LiveView event information to the context only during exceptions and avoids the situations mentioned above. The LiveView name, URL and URL params are still part of the process context as that information is helpful to understand what was going on before the error happened. This is consistent with the LiveComponent error handled implemented in #74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #73