Allow saving occurrences with invalid context #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates how an occurrence is stored in order to validate if the context can be serialized to be stored on the database. If the context cannot be serialized, we emit a warning log message and store an error as the context.
odarriba
commented
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates how an occurrence is stored in order to validate if the context can be serialized to be stored on the database.
If the context cannot be serialized, we emit a warning log message and store an error as the context.
Extra tests have been added for the new functionality.
Note: This is a proposal. I think it may be a good idea but it adds a bit more of complexity on occurrence building. On the other hand, we avoid having issues which are invisible to our users by not storing them.
Closes #65 (again)