Do not store error if context/occurrence is not valid #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odarriba
force-pushed
the
do-not-store-error-if-occurrence-is-not-valid
branch
from
67b7684 to
75a3e47
Compare
crbelaus
approved these changes
Aug 24, 2024
|
Hey, that's nice, I just tried to put the whole User struct and I got this, as expected. Good work, thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solves an issue in which an invalida content of the error context
case the
Errorschema to be stored but not theOccurrence, which means thatthe error appears on the dashboard list but cannot be opened because the details
were not stored.
On this change I change the store procedure to use a DB transaction and ensure
that, if something fails, no data is stored and an exception is generated.
I thought about storing that exception ourselves but if the issue is not related
to the data stored but other parts of the stack (network, DB, etc) it can end up
in an infinite loop.
I have also updated the documentation so it states the requirements needed for
the context data to be stored (basically, it has to be convertible to JSON).
Closes #65