Use CSP nonces for script and style tags #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
:csp_nonce_assign_keyoption to theerror_tracker_dashboard/2macro. If provided, the error tracker will fetch the nonce from the given assign key and use it in the<style>and<script>tags.This allows using the ErrorTracker dashboard in environments with a restricted content security policy without requiring the usage of
unsafe-inline, which should be avoided.This implementation is based on the Phoenix LiveDashboard one.
I've updated the
dev.exsscript to use CSP headers. If we remove the new option we will see that the ErrorTracker dashboard doesn't have any styles.Closes #58