Skip to content

Mute error occurrences #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 3, 2025
Merged

Mute error occurrences #130

merged 14 commits into from
Mar 3, 2025

Conversation

crbelaus
Copy link
Contributor

@crbelaus crbelaus commented Feb 14, 2025 •
edited
Loading

This pull request adds a new muted field to errors. Noisy errors can be muted in the UI so integrations and notifications can ignore them as well.

In the end I decided to use the mute instead of silence as I think that mute and unmute are fairly commonly understood terms.

This is an addition to the capability of ignoring errors that we already have, and enables the possibility of tracking error occurrences but don't notify them. Closes #117

New mute action in the error detail page:
New mute action in the error detail page

Mute and unmute actions in the dashboard page
Mute and unmute actions in the dashboard page

crbelaus
crbelaus commented Feb 14, 2025
View reviewed changes
@crbelaus crbelaus changed the title Mute errors Mute error occurrences Feb 15, 2025
@crbelaus crbelaus marked this pull request as ready for review February 15, 2025 07:36
@crbelaus crbelaus requested a review from odarriba February 15, 2025 07:36
@crbelaus crbelaus mentioned this pull request Feb 15, 2025
Closed
@crbelaus crbelaus self-assigned this Feb 22, 2025
odarriba
odarriba approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@odarriba odarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I added some comments but all of them minor.

My only worry is that I don't know if it is better to avoid sending telemetry events, or send them with a muted: true information.

crbelaus added 3 commits March 2, 2025 10:28
@crbelaus
Include muted and error metadata for new occurrence telemetry
1fb42cf 
Aside from the occurrence itself, the new occurrence telemetry event now
also includes the error and the muted flag so users can choose wether
the occurrence should be reported or not.
@crbelaus
Don't set the default muted value in Elixir
b0a02ab
@crbelaus
Update docs
a3945c1
@crbelaus
Copy link
Contributor Author

crbelaus commented Mar 2, 2025

My only worry is that I don't know if it is better to avoid sending telemetry events, or send them with a muted: true information.

This makes sense. I've updated the code so the [:error_tracker, :occurrence, :new] telemetry event is always emitted but it now also includes a muted metadata so users can ignore those events as needed. Since we are adding more metadata I've also added the error in case it may be useful.

I've also updated the documentation to reflect this changes.

@crbelaus crbelaus requested a review from odarriba March 2, 2025 09:47
odarriba
odarriba approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@odarriba odarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🤌

@crbelaus crbelaus merged commit 5f5d814 into main Mar 3, 2025
4 checks passed
@crbelaus crbelaus deleted the mute-errors branch March 3, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odarriba odarriba odarriba approved these changes

Assignees

@crbelaus crbelaus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature suggestion: ignore certain errors
2 participants
@crbelaus @odarriba