Skip to content

Integrate breadcrumbs #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 23, 2024
Merged

Integrate breadcrumbs #107

merged 17 commits into from
Nov 23, 2024

Conversation

odarriba
Copy link
Contributor

@odarriba odarriba commented Nov 9, 2024

This change adds support for breadcrumbs as a first-class field on our occurrences.

Breadcrumbs are now a way to store a list of strings indicating in which order they were added, so they can be used to track which code was executed and on which order. They are managed per-process (which in Phoenix means per-request in general)

  • A new section in occurrence detail LiveView was added
  • Some helper functions to add and list breadcrumbs were added
  • The integration with Ash and Splode was updated to match the new system
  • Some tests were added
  • A new migration was added to create the new field

@odarriba odarriba self-assigned this Nov 9, 2024
@odarriba
Copy link
Contributor Author

Early review before doing docs and so on is appreciated @crbelaus can you take a look? 👀

@crbelaus
Copy link
Contributor

I've pushed a small commit that adds a CustomException with bread crumbs so we can check how they interact with the breadcrumbs sent by ErrorTracker.add_breadcrumb/1.

@odarriba odarriba changed the title WIP: Integrate bread crumbs WIP: Integrate breadcrumbs Nov 21, 2024
@odarriba odarriba changed the title WIP: Integrate breadcrumbs Integrate breadcrumbs Nov 21, 2024
@odarriba odarriba requested a review from crbelaus November 21, 2024 19:53
@odarriba
Copy link
Contributor Author

Ready to review again @crbelaus 🙌

Copy link
Contributor

@crbelaus crbelaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 🚀

@odarriba odarriba merged commit cc6aacb into main Nov 23, 2024
3 checks passed
@odarriba odarriba deleted the integrate-breadcrumbs branch November 23, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants