Skip to content

Fix syntax highlighting with "~S" sigil #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Fix syntax highlighting with "~S" sigil #457

merged 1 commit into from
Dec 12, 2018

Conversation

feliperenan
Copy link
Contributor

@feliperenan feliperenan commented Dec 12, 2018

Fixes #438

Just changed to use the same pattern used in elixirString

syn region elixirString matchgroup=elixirStringDelimiter start=+\z('''\)+ end=+^\s*\z1+ contains=@Spell,@elixirStringContained

Before

image

image

After

image

image

@jbodah
Copy link
Collaborator

jbodah commented Dec 12, 2018

Thanks, looks great! Would you mind adding a test for this?

Here's an example: https://github.com/elixir-editors/vim-elixir/blob/master/spec/syntax/doc_spec.rb#L27-L36

I'll run those prior on my machine and merge if it all looks good

@feliperenan
Copy link
Contributor Author

@jbodah Tests added. I'm not sure if they are covering the scenarios correctly though, could you please take a look?

@jbodah
Copy link
Collaborator

jbodah commented Dec 12, 2018

Looks good - thanks again!

@jbodah jbodah merged commit 7e65a35 into elixir-editors:master Dec 12, 2018
@feliperenan feliperenan deleted the fix-sigils-syntax branch December 12, 2018 23:08
kelvinst pushed a commit to kelvinst/vim-elixir that referenced this pull request Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants