Skip to content

elixirDocString's own their ends. #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2016

Conversation

lmarlow
Copy link
Contributor

@lmarlow lmarlow commented Dec 2, 2016

This prevents doc tests leaking past the end of the docstring.

Fixes #230

This prevents doc tests leaking past the end of the docstring.

Fixes elixir-editors#230
@tsubery
Copy link

tsubery commented Dec 2, 2016

Is there a reason not to add keepend parameter to all 9 definitions of "elixirDocString" region?

@kassio kassio merged commit 5bba2b3 into elixir-editors:master Dec 2, 2016
@lmarlow
Copy link
Contributor Author

lmarlow commented Dec 2, 2016

@tsubery, laziness is the answer. I haven't seen many uses of those for docs. I wrote a few more tests and it was a problem with those cases as well, which leads to #235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants