Move the indentation rules to autoload functions #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify the `indent/elixir.vim` moving all the indentation rules to `autoload/indent.vim`. The indent script is responsible now for call the rules, not define them. - Rename `GetElixirIndent` to `elixir#indent`. - Use constants with SCREAM_CASE. - Each rule function now receives the current indentation and a line dictionary, which contains the current and last lines number and texts.
|
No strong opinion from me either way. Looks cleaner 👍 |
|
Breaks (disables) indentation completely when is used with Vundle master. |
|
@sumerman can you create an issue please? |
|
@kassio I was unsuccessfully trying to create a minimal example. It turns out the problem was present only in one stored session. Therefore it's not an actual issue. My apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason of this is try to simplify the rules definition.
indent/elixir.vimmoving all the indentation rules toautoload/indent.vim. The indent script is responsible now for call therules, not define them.
GetElixirIndenttoelixir#indent.dictionary, which contains the current and last lines number and texts.
@jbodah can you gimme your 2 cents here?