Skip to content

Sigil heredoc support #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Sigil heredoc support #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elixir-mode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ is used to limit the scan."
(unless (elixir-syntax-in-string-or-comment-p)
(let ((heredoc-p (save-excursion
(goto-char (match-beginning 0))
(looking-at-p "~[sS]\\(?:'''\\|\"\"\"\\)"))))
(looking-at-p "~[BCDELNRSTUbcersw]\\(?:'''\\|\"\"\"\\)"))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axelson we should generate tests for these new sigils as it's really easy to break and not notice day-to-day.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good point and it would be good to include tests for them

(unless heredoc-p
(forward-char 1)
(let* ((start-delim (char-after (1- (point))))
Expand Down