Make usable again in Emacs 27 #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid backtracking and thus improve font-locking performance. Necessary in Emacs 27 because of some correctness improvements in 'rx'. Suggested by Mattias Engdegård in https://debbugs.gnu.org/38104.
They never did anything anyway because 'identifiers' doesn't include any separators, so the resulting construct could only match one identifier anyway.
|
why it did work prior some recentish emacs 27 commits? |
|
As explained in the linked discussion, it was an old bug in |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is now, it freezes on opening any non-trivial file (it's actually just applying font-lock rules very slowly).
It is a bug in elixir-mode, not Emacs. See https://debbugs.gnu.org/38104#20 for full explanation.
Fixes #445.