Skip to content

Validated watcher.stats Response #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

Validated watcher.stats Response #242

merged 1 commit into from
Mar 29, 2021

Conversation

philkra
Copy link
Contributor

@philkra philkra commented Mar 26, 2021

as titled.

@delvedor, I wanted to validated the request as well but ran into a type casting issue:

expectAssignable<T.WatcherStatsRequest>({
  "metric": "all",
  "emit_stacktraces": "true"
})

and emit_stacktraces is of type boolean in WatcherStatsRequest.ts 🤷

@philkra philkra requested a review from delvedor March 26, 2021 20:42
delvedor
delvedor approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very likely the yaml test is using "true" instead of true. It should be fixed there.

@delvedor delvedor merged commit bfd0f24 into master Mar 29, 2021
@delvedor delvedor deleted the watcher.stats branch March 29, 2021 07:53
l-trotta added a commit that referenced this pull request Feb 8, 2024
@l-trotta
making node info path optional (issue #242)
c795a05
l-trotta added a commit that referenced this pull request Feb 8, 2024
@l-trotta
making node info discover seed_host optional (issue #242)
6f8ef94
l-trotta added a commit that referenced this pull request Feb 8, 2024
@l-trotta
initial_master_nodes from string to string[] (issue #242)
9b15e45
l-trotta added a commit that referenced this pull request Feb 19, 2024
@l-trotta
correct node info discover class (issue #242)
52a1aca
l-trotta added a commit that referenced this pull request Feb 19, 2024
@l-trotta
Batch from java issues (#2412)
d792c32 
* added 'remove_binary' to AttachmentProcessor (issue #727)

* making node info path optional (issue #242)

* making node info discover seed_host optional (issue #242)

* changed description for update by query  (issue #315)

* adding custom options to index settings similarity (issue #299)

* initial_master_nodes from string to string[] (issue #242)

* correct contrib

* correct node info discover class (issue #242)
l-trotta added a commit that referenced this pull request Feb 19, 2024
@l-trotta
making node info path optional (issue #242)
11a213c
l-trotta added a commit that referenced this pull request Feb 19, 2024
@l-trotta
making node info discover seed_host optional (issue #242)
b62d342
l-trotta added a commit that referenced this pull request Feb 19, 2024
@l-trotta
initial_master_nodes from string to string[] (issue #242)
f193c22
l-trotta added a commit that referenced this pull request Feb 19, 2024
@l-trotta
correct node info discover class (issue #242)
587de6c
l-trotta added a commit that referenced this pull request Feb 19, 2024
@l-trotta
Java client issues fixes backport (#2419)
ce97fb5 
* added 'remove_binary' to AttachmentProcessor (issue #727)

* making node info path optional (issue #242)

* making node info discover seed_host optional (issue #242)

* changed description for update by query  (issue #315)

* initial_master_nodes from string to string[] (issue #242)

* correct node info discover class (issue #242)

* generate and contrib
l-trotta added a commit that referenced this pull request Feb 19, 2024
@l-trotta
Batch from java issues (#2412)
b9501c9 
* added 'remove_binary' to AttachmentProcessor (issue #727)

* making node info path optional (issue #242)

* making node info discover seed_host optional (issue #242)

* changed description for update by query  (issue #315)

* adding custom options to index settings similarity (issue #299)

* initial_master_nodes from string to string[] (issue #242)

* correct contrib

* correct node info discover class (issue #242)
l-trotta added a commit that referenced this pull request Feb 19, 2024
@l-trotta
Backport 2412 to 8.13 (#2420)
31beaf3 
* Batch from java issues (#2412)

* added 'remove_binary' to AttachmentProcessor (issue #727)

* making node info path optional (issue #242)

* making node info discover seed_host optional (issue #242)

* changed description for update by query  (issue #315)

* adding custom options to index settings similarity (issue #299)

* initial_master_nodes from string to string[] (issue #242)

* correct contrib

* correct node info discover class (issue #242)

* contrib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philkra @delvedor