Skip to content

TypeScript fixes #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 17, 2023
Merged

TypeScript fixes #2242

merged 5 commits into from
Aug 17, 2023

Conversation

JoshMock
Copy link
Member

Several new APIs were not exporting their Request interfaces. Also found some files importing modules they weren't using or that didn't exist, and noticed a few paths missing from the tsconfig.

@JoshMock
Copy link
Member Author

I haven't verified this, but I'm curious if some of these fixes will clear up some odd output I've seen from Python codegen this week.

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JoshMock JoshMock requested a review from a team as a code owner August 17, 2023 19:11
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
query_ruleset.delete Missing test Missing test
query_ruleset.get Missing test Missing test
query_ruleset.list Missing test Missing test
query_ruleset.put Missing test Missing test
search_application.delete_behavioral_analytics Missing test Missing test
search_application.delete Missing test Missing test
search_application.get_behavioral_analytics Missing test Missing test
search_application.get Missing test Missing test
search_application.list Missing test Missing test
search_application.put_behavioral_analytics Missing test Missing test
search_application.put Missing test Missing test
search_application.search Missing test Missing test
synonyms.delete_synonym_rule Missing test Missing test
synonyms.delete_synonym Missing test Missing test
synonyms.get_synonym_rule Missing test Missing test
synonyms.get_synonym Missing test Missing test
synonyms.get_synonyms_sets Missing test Missing test
synonyms.put_synonym_rule Missing test Missing test
synonyms.put_synonym Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants