Skip to content

IndicesPrivileges can contain multiple queries #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

swallez
Copy link
Member

@swallez swallez commented Oct 17, 2022

As titled.

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.activate_user_profile 🟢 8/8 8/8
security.authenticate 🟢 19/19 19/19
security.bulk_update_api_keys 🟠 Missing type Missing type
security.change_password 🟢 6/6 6/6
security.clear_api_key_cache 🟢 12/12 12/12
security.clear_cached_privileges 🟢 3/3 3/3
security.clear_cached_realms 🟢 1/1 1/1
security.clear_cached_roles 🟢 2/2 2/2
security.clear_cached_service_tokens 🟢 4/4 4/4
security.create_api_key 🟢 41/41 32/32
security.create_service_token 🟢 3/3 3/3
security.delete_privileges 🟢 6/6 6/6
security.delete_role_mapping 🟢 9/9 9/9
security.delete_role 🟢 8/8 8/8
security.delete_service_token Missing test Missing test
security.delete_user 🟢 9/9 9/9
security.disable_user_profile 🟢 1/1 1/1
security.disable_user 🟢 3/3 3/3
security.enable_user_profile 🟢 1/1 1/1
security.enable_user 🟢 4/4 4/4
security.enroll_kibana Missing test Missing test
security.enroll_node Missing test Missing test
security.get_api_key 🟢 28/28 28/28
security.get_builtin_privileges 🟢 2/2 2/2
security.get_privileges 🟢 12/12 12/12
security.get_role_mapping 🟢 18/18 18/18
security.get_role 🟢 20/20 20/20
security.get_service_accounts Missing test Missing test
security.get_service_credentials 🟢 1/1 1/1
security.get_token 🟢 23/23 22/22
security.get_user_privileges 🟢 7/7 7/7
security.get_user_profile 🟢 8/8 8/8
security.get_user 🟢 25/25 25/25
security.grant_api_key 🟢 7/7 7/7
security.has_privileges_user_profile 🟢 3/3 3/3
security.has_privileges 🟢 21/21 21/21
security.invalidate_api_key 🟢 10/10 10/10
security.invalidate_token 🟢 11/11 11/11
security.oidc_authenticate 🟠 Missing type Missing type
security.oidc_logout 🟠 Missing type Missing type
security.oidc_prepare_authentication 🟠 Missing type Missing type
security.put_privileges 🟢 10/10 10/10
security.put_role_mapping 🟢 11/11 11/11
security.put_role 🟢 35/35 34/34
security.put_user 🟢 43/43 42/42
security.query_api_keys 🟢 9/9 9/9
security.saml_authenticate Missing test Missing test
security.saml_complete_logout Missing test Missing test
security.saml_invalidate Missing test Missing test
security.saml_logout Missing test Missing test
security.saml_prepare_authentication Missing test Missing test
security.saml_service_provider_metadata Missing test Missing test
security.suggest_user_profiles 🟢 1/1 1/1
security.update_api_key 🟢 4/4 4/4
security.update_user_profile_data 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@swallez swallez merged commit 3bc6627 into main Oct 17, 2022
@swallez swallez deleted the fix-index-privileges-query branch October 17, 2022 17:26
swallez added a commit that referenced this pull request Oct 17, 2022
Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
swallez added a commit that referenced this pull request Oct 17, 2022
Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
swallez added a commit that referenced this pull request Oct 18, 2022
@swallez swallez mentioned this pull request Oct 18, 2022
swallez added a commit that referenced this pull request Oct 19, 2022
* Revert "IndicesPrivileges can contain multiple queries (#1963)"

This reverts commit 3bc6627.

* Fix IndicesPrivileges and RoleTemplateScript
github-actions bot pushed a commit that referenced this pull request Oct 19, 2022
* Revert "IndicesPrivileges can contain multiple queries (#1963)"

This reverts commit 3bc6627.

* Fix IndicesPrivileges and RoleTemplateScript
swallez added a commit that referenced this pull request Oct 19, 2022
* Revert "IndicesPrivileges can contain multiple queries (#1963)"

This reverts commit 3bc6627.

* Fix IndicesPrivileges and RoleTemplateScript

Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
swallez added a commit that referenced this pull request Oct 19, 2022
* Revert "IndicesPrivileges can contain multiple queries (#1963)"

This reverts commit 3bc6627.

* Fix IndicesPrivileges and RoleTemplateScript
swallez added a commit that referenced this pull request Oct 19, 2022
* Revert "IndicesPrivileges can contain multiple queries (#1963)"

This reverts commit 3bc6627.

* Fix IndicesPrivileges and RoleTemplateScript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants