Skip to content

Fix suggestion options and mapping char filter #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Conversation

swallez
Copy link
Member

@swallez swallez commented Jul 12, 2022

Fixes issues found in the Java client:

@swallez swallez added backport 7.17 lang:java Affects/found in the Java client backport 8.3 labels Jul 12, 2022
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 1469/1524 1493/1506

You can validate this API yourself by using the make validate target.

@swallez swallez merged commit 3c092a8 into main Jul 12, 2022
@swallez swallez deleted the java-client-fixes-220712 branch July 12, 2022 17:04
@github-actions
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1783-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 3c092a8a0a88fd011a976c836049fcedec1fe3c3
# Push it to GitHub
git push --set-upstream origin backport-1783-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-1783-to-7.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants