Skip to content

Remove unnecessary ScoreFunctionBase #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Remove unnecessary ScoreFunctionBase #1666

merged 1 commit into from
Apr 29, 2022

Conversation

swallez
Copy link
Member

@swallez swallez commented Apr 29, 2022

The field and filter parameters of function score queries are defined in the enclosing FunctionScoreQuery object, and not in the function definition itself. ScoreFunctionQueryBase is therefore unnecessary.

Also removes WeightScoreFunction that is still there but not referenced.

Verified in ES source code, make validate api=search type=request doesn't show new errors after this change.

@swallez swallez merged commit 4cbdef1 into main Apr 29, 2022
@swallez swallez deleted the fix-function-score branch April 29, 2022 11:57
github-actions bot pushed a commit that referenced this pull request Apr 29, 2022
github-actions bot pushed a commit that referenced this pull request Apr 29, 2022
swallez added a commit that referenced this pull request Apr 29, 2022
Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
swallez added a commit that referenced this pull request Apr 29, 2022
Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants