Ensure qaf knows it's running in CI #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Still failing but for new reasons. Switching to draft so I can figure this out. |
JoshMock
force-pushed
the
qaf-buildkite
branch
from
15e690e to
d1dcc20
Compare
|
Missing a permission to a shared secret in Vault. Waiting on a CI config change before retesting this. |
|
The latest build on this PR shows integration tests are still failing, but it seems able to fetch secrets appropriately, so I'll merge this fix for that specific issue. @pquentin Figuring out what is causing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest tests of the
qafintegration test runner are getting confused about which Vault instance to connect to. I forgot we needed to make sure the Docker image knows it's running in Buildkite in order to access Vault CI.