Skip to content

Add Certificate newtype that supports CA chains. #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

Add Certificate newtype that supports CA chains. #101

merged 1 commit into from
May 28, 2020

Conversation

reyk
Copy link
Contributor

@reyk reyk commented May 28, 2020

Proposed fix for #100

@cla-checker-service
Copy link

cla-checker-service bot commented May 28, 2020 •
edited
Loading

💚 CLA has been signed

@reyk reyk force-pushed the fix/certificate-chains branch from 5771e8a to df01509 Compare May 28, 2020 14:11
@reyk reyk mentioned this pull request May 28, 2020
Closed
@reyk reyk force-pushed the fix/certificate-chains branch from df01509 to f6fd07f Compare May 28, 2020 14:13
@reyk
Copy link
Contributor Author

reyk commented May 28, 2020

Let me replace the Let’s Encrypt CA with an example CA that I created myself.

@reyk reyk force-pushed the fix/certificate-chains branch from f6fd07f to cceed45 Compare May 28, 2020 14:39
russcam
russcam approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit 041d5f6 into elastic:master May 28, 2020
@russcam
Copy link
Contributor

russcam commented May 28, 2020

thanks @reyk!

russcam pushed a commit that referenced this pull request May 28, 2020
@reyk @russcam
Add Certificate newtype that supports CA chains. (#101)
ef3dd9f 
This commit adds a Certificate type to the library that
supports a certificate chain in PEM encoded format.

Fixes #100

(cherry picked from commit 041d5f6)
russcam pushed a commit that referenced this pull request May 28, 2020
@reyk @russcam
Add Certificate newtype that supports CA chains. (#101)
c024979 
This commit adds a Certificate type to the library that
supports a certificate chain in PEM encoded format.

Fixes #100

(cherry picked from commit 041d5f6)
@russcam russcam added breaking-change A breaking change in the public API enhancement New feature or request v7.7.1-alpha.1 labels May 29, 2020
@reyk
Copy link
Contributor Author

reyk commented May 29, 2020

Thank you for the quick response and release, that’s awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russcam russcam russcam approved these changes

Assignees
No one assigned
Labels
breaking-change A breaking change in the public API enhancement New feature or request v7.7.1-alpha.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyk @russcam