Skip to content

Add Connector API #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2024
Merged

Add Connector API #2621

merged 1 commit into from
Aug 2, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Aug 1, 2024

As added in #2531 initially, but reverted in #2553 because it was not ready for 8.14.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@pquentin pquentin changed the title Add Connector API (#2531) Add Connector API Aug 1, 2024
@pquentin pquentin requested a review from miguelgrinberg August 1, 2024 13:59
miguelgrinberg
miguelgrinberg approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@miguelgrinberg miguelgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, I feel great about allowing this type of change because the request-converter indirectly is going to make sure the client is doing the right thing here.

@pquentin pquentin merged commit 928bdb7 into elastic:main Aug 2, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 2, 2024
@pquentin @github-actions
Add Connector API (#2621)
d3aef10 
(cherry picked from commit 928bdb7)
@github-actions github-actions bot mentioned this pull request Aug 2, 2024
Merged
This was referenced Aug 2, 2024
Merged
Merged
pquentin added a commit that referenced this pull request Aug 2, 2024
@github-actions @pquentin
[Backport 8.15] Add Connector API (#2623)
90fddf4 
* Add Connector API (#2621)

(cherry picked from commit 928bdb7)

* Fix Connector API

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
@pquentin pquentin deleted the connector-api branch November 6, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgrinberg miguelgrinberg miguelgrinberg approved these changes

Assignees
No one assigned
Labels
backport 8.15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @miguelgrinberg