[Backport 8.15] feat: extend default settings in AsyncVectorStore #2610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* feat: extend default settings in AsyncVectorStore This commit introduces a new parameter, custom_settings, to the AsyncVectorStore class. This allows users to provide their own settings that will extend the default settings. This increases the flexibility of the class and allows it to be tailored to specific use cases. The custom settings are applied in the _create_index_if_not_exists method. * Update vectorstore.py * Update vectorstore.py apply changes in vectorstore * Update vectorstore.py format the py file * Update test_vectorstore.py add test_custom_index_settings in test_vectorstore * Update test_vectorstore.py * Update vectorstore.py fix file format * Update test_vectorstore.py fix format * Update vectorstore.py add error tips in vectorstore when confilicting the settings * Update vectorstore.py * Update vectorstore.py modify the comments of the param custom_index_settings * Update vectorstore.py * add settings conflict test * reformat --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com> (cherry picked from commit beb03de)
miguelgrinberg
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport beb03de from #2602.