Skip to content

Remove unneeded refreshes in tests #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024
Merged

Remove unneeded refreshes in tests #2574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions test_elasticsearch/test_async/test_server/test_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ async def test_all_errors_from_chunk_are_raised_on_failure(self, async_client):
mappings={"properties": {"a": {"type": "integer"}}},
settings={"number_of_shards": 1, "number_of_replicas": 0},
)
await async_client.cluster.health(wait_for_status="yellow")

try:
async for ok, item in helpers.async_streaming_bulk(
Expand Down Expand Up @@ -338,7 +337,6 @@ async def test_errors_are_reported_correctly(self, async_client):
mappings={"properties": {"a": {"type": "integer"}}},
settings={"number_of_shards": 1, "number_of_replicas": 0},
)
await async_client.cluster.health(wait_for_status="yellow")

success, failed = await helpers.async_bulk(
async_client,
Expand All @@ -364,7 +362,6 @@ async def test_error_is_raised(self, async_client):
mappings={"properties": {"a": {"type": "integer"}}},
settings={"number_of_shards": 1, "number_of_replicas": 0},
)
await async_client.cluster.health(wait_for_status="yellow")

with pytest.raises(helpers.BulkIndexError):
await helpers.async_bulk(async_client, [{"a": 42}, {"a": "c"}], index="i")
Expand Down Expand Up @@ -408,7 +405,6 @@ async def test_errors_are_collected_properly(self, async_client):
mappings={"properties": {"a": {"type": "integer"}}},
settings={"number_of_shards": 1, "number_of_replicas": 0},
)
await async_client.cluster.health(wait_for_status="yellow")

success, failed = await helpers.async_bulk(
async_client,
Expand Down
4 changes: 0 additions & 4 deletions test_elasticsearch/test_server/test_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ def test_bulk_all_errors_from_chunk_are_raised_on_failure(sync_client):
"settings": {"number_of_shards": 1, "number_of_replicas": 0},
},
)
sync_client.cluster.health(wait_for_status="yellow")

try:
for ok, _ in helpers.streaming_bulk(
Expand Down Expand Up @@ -325,7 +324,6 @@ def test_errors_are_reported_correctly(sync_client):
mappings={"properties": {"a": {"type": "integer"}}},
settings={"number_of_shards": 1, "number_of_replicas": 0},
)
sync_client.cluster.health(wait_for_status="yellow")

success, failed = helpers.bulk(
sync_client,
Expand All @@ -352,7 +350,6 @@ def test_error_is_raised(sync_client):
mappings={"properties": {"a": {"type": "integer"}}},
settings={"number_of_shards": 1, "number_of_replicas": 0},
)
sync_client.cluster.health(wait_for_status="yellow")

with pytest.raises(helpers.BulkIndexError):
helpers.bulk(
Expand Down Expand Up @@ -399,7 +396,6 @@ def test_errors_are_collected_properly(sync_client):
mappings={"properties": {"a": {"type": "integer"}}},
settings={"number_of_shards": 1, "number_of_replicas": 0},
)
sync_client.cluster.health(wait_for_status="yellow")

success, failed = helpers.bulk(
sync_client,
Expand Down
Loading