[DOCS] Adds a signpost for downloading ES or signing-up for ESS #2384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
requested changes
Nov 27, 2023
There was a problem hiding this comment.
The README file is (unfortunately) ReST, not Markdown, see https://github.com/elastic/elasticsearch-py/blob/bfa8db26287b5c961a01e7445552a716a5696995/README.rst for the current result.
Additionally, should we update the Sphinx and Elasticsearch docs?
szabosteve
commented
Nov 27, 2023
szabosteve
commented
Nov 27, 2023
|
@pquentin I addressed your comment via the last commits. |
pquentin
reviewed
Dec 1, 2023
There was a problem hiding this comment.
Thanks! What are your thoughts on moving those to the installation sections?
- README.rst: either remove this or put it just before "Refer to the Installation section"
- guide: either in https://www.elastic.co/guide/en/elasticsearch/client/python-api/current/getting-started-python.html#_installation or in the installation page itself.
- sphinx: I think this one works 👍
|
@pquentin Keeping a signpost in the repo README about the download locations is kind of the whole point of this PR, so I wouldn't remove it, so I put it in the place you suggested. |
|
buildkite test this please |
pquentin
approved these changes
Dec 4, 2023
|
@elasticmachine test this please |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 336319d)
pquentin
added a commit
that referenced
this pull request
Dec 8, 2023
…up for ESS (#2396) * [DOCS] Adds a signpost for downloading ES or signing-up for ESS (#2384) Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 336319d) * Trigger CI --------- Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a signpost to the repo README that links to the ES download page and to the ESS sign-up page.