Switch from invariant List to covariant Sequence #2324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshMock
approved these changes
Oct 5, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
(cherry picked from commit 8affaa7)
This was referenced Oct 6, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
(cherry picked from commit 8affaa7)
pquentin
pushed a commit
that referenced
this pull request
Oct 6, 2023
pquentin
pushed a commit
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2273
To make the snippet from @floxay in #2273 work, I had to explicitly type
searches_listasList[Mapping[str, Any]], otherwise I was getting: