-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Docs] Link to Elasticsearch labs on landing pages #2281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, @leemthompo! Very nice addition! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! Would it help to mention that the focus is on, well, AI?
@pquentin we also have "classical search" stuff in notebooks but I could update to say something like "...to test out Elasticsearch for vector search, hybrid search and generative AI use cases." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating! LGTM.
@pquentin @szabosteve sorry didn't realise the landing page lived in same repo (was planning to open another PR), so I've just pushed another commit to add a link to the Elastic docs landing page. István let me know if banner is suitable or if I should find somewhere else on the landing page to add this link :-) ![]() |
readthedocs
landing pageThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2! 🎉
It would be nice to have @JoshMock opinion, too.
This all looks great to me. 👍 |
@JoshMock do we need to worry about the 1 failing check? |
Nope, that's an expected failure. A (very) thorough integration test suite that is effectively impossible to pass without skipping a bunch of tests. 😆 We're hoping to pursue a better path for those tests soon. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* Link to Elasticsearch labs in readme * Add banner linking labs on Elastic docs landing page (cherry picked from commit c137fea)
First PR in this repo and first line of
reStructuredText
written 😄.Adds links to Elasticsearch labs in two places:
ℹ️ Not sure about how labels work for this repo!