Skip to content

[Docs] Link to Elasticsearch labs on landing pages #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Aug 29, 2023

First PR in this repo and first line of reStructuredText written 😄.

Adds links to Elasticsearch labs in two places:

  • readthedocs landing page
  • Elastic docs landing page

ℹ️ Not sure about how labels work for this repo!

szabosteve
szabosteve previously approved these changes Aug 29, 2023
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, @leemthompo! Very nice addition! LGTM!

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Would it help to mention that the focus is on, well, AI?

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
@leemthompo
Copy link
Contributor Author

@pquentin we also have "classical search" stuff in notebooks but I could update to say something like "...to test out Elasticsearch for vector search, hybrid search and generative AI use cases."

pquentin
pquentin previously approved these changes Aug 29, 2023
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating! LGTM.

@leemthompo
Copy link
Contributor Author

@pquentin @szabosteve sorry didn't realise the landing page lived in same repo (was planning to open another PR), so I've just pushed another commit to add a link to the Elastic docs landing page.

István let me know if banner is suitable or if I should find somewhere else on the landing page to add this link :-)

Screenshot 2023-08-29 at 12 49 25

@leemthompo leemthompo changed the title [Docs] Link to Elasticsearch labs on readthedocs landing page [Docs] Link to Elasticsearch labs on landing pages Aug 29, 2023
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2! 🎉
It would be nice to have @JoshMock opinion, too.

@JoshMock
Copy link
Member

This all looks great to me. 👍

@leemthompo
Copy link
Contributor Author

@JoshMock do we need to worry about the 1 failing check?

@JoshMock
Copy link
Member

Nope, that's an expected failure. A (very) thorough integration test suite that is effectively impossible to pass without skipping a bunch of tests. 😆 We're hoping to pursue a better path for those tests soon.

@leemthompo
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

leemthompo added a commit that referenced this pull request Aug 31, 2023
* Link to Elasticsearch labs in readme

* Add banner linking labs on Elastic docs landing page

(cherry picked from commit c137fea)
leemthompo added a commit that referenced this pull request Aug 31, 2023
* Link to Elasticsearch labs in readme

* Add banner linking labs on Elastic docs landing page

(cherry picked from commit c137fea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants