Skip to content

Fixes incorrect reference in documentation #5558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Fixes incorrect reference in documentation #5558

merged 2 commits into from
Apr 21, 2021

Conversation

MEmanuelsson
Copy link

Fixes incorrect reference to "MyFirstCustomJsonNetSerializer" in documentation

Fixes incorrect reference to "MyFirstCustomJsonNetSerializer" in documentation
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 20, 2021

💚 CLA has been signed

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will need to be made at source in CustomSerialization.doc.cs which is used to generate this asciidoc file using .\build.bat documentation.

@stevejgordon
Copy link
Contributor

Thanks for submitting this PR @MEmanuelsson. This is a generated file so the change would need to be made in CustomSerialization.doc.cs instead. If you're up for that, could you please amend this PR. You can run the docs generator afterwards to produce the asciidoc. If you're unable to make that change, no worries. Please let me know and I can close this and open a PR with the fix into the cs file.

@MEmanuelsson
Copy link
Author

No problem @stevejgordon, pushed an update to CustomSerialization.doc.cs just now.

Ran .\build.bat documentation after the update to verify the change, this also results in some other asciidoc-files being updated but decided not to push these updates to the repo, right or wrong?

image

@stevejgordon
Copy link
Contributor

This is perfect, thanks @MEmanuelsson! You made the correct call on the other generator changes. Some of those went into the branch yesterday and the deletions is a bug. I'll merge this in and handle backporting this to our other branches. Your help is very much appreciated.

@stevejgordon stevejgordon merged commit 358b766 into elastic:7.x Apr 21, 2021
@MEmanuelsson MEmanuelsson deleted the patch-1 branch April 21, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants