Update RuntimeField to use IInlineScript #5546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejgordon
added a commit
that referenced
this pull request
Apr 23, 2021
(cherry picked from commit 8d04047)
stevejgordon
added a commit
that referenced
this pull request
Apr 23, 2021
stevejgordon
added a commit
that referenced
this pull request
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime fields now support parameters in their scripts which the current
IStoredScriptinterface does not support. This change updates to preferIInlineScriptwhich better aligns to the functionality of scripts in runtime fields.This is a breaking change but should have a limited impact on existing users and ultimately is worth making to allow consumers to fully utilise runtime fields. Only code currently using runtime fields and the object initialiser syntax will need to be updated. The change is required is to create an instance of
InlineScriptrather thanPainlessScript.Fixes #5537