Skip to content

[Backport 6.x] Implement meta header for client requests #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

stevejgordon
Copy link
Contributor

Backport fec16ef from #5190

@Mpdreamz This backports the work in 7.x for the meta header to 6.x. Some changes had to be made to get it to compile and function. A few types needed to be made public rather than internal as it seems NEST cannot use Elasticsearch.NET internals in 6.x. Integration tests work as expected against latest-6 and all unit tests are passing. I observed the header on the integration test requests.

(cherry picked (and adapted) from commit fec16ef)
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM 👍

@stevejgordon
Copy link
Contributor Author

I've pushed one change to an unrelated test which is failing on 6.0.1 and needs to be skipped since it uses a parameter not available in that version. Once CI re-runs I'll merge!

@stevejgordon stevejgordon merged commit 3472e7b into 6.x Feb 8, 2021
@stevejgordon stevejgordon deleted the backport-5190-to-6.x branch February 8, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants