-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement Clone Snapshot API #5240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement new API - Remove CRUD snapshot tests and replace with coordinated tests
Mpdreamz
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Might need a |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 7, 2021
Implement Clone Snapshot API - Implement new API - Remove CRUD snapshot tests and replace with coordinated tests - Move tests to IntrusiveOperationCluster
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-5240-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 a96cfffc8ba1be0b9da437f218f683f5b646013d
# Push it to GitHub
git push --set-upstream origin backport-5240-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-master Then, create a pull request where the |
stevejgordon
added a commit
that referenced
this pull request
Jan 11, 2021
stevejgordon
added a commit
that referenced
this pull request
Jan 14, 2021
Implement Clone Snapshot API - Implement new API - Remove CRUD snapshot tests and replace with coordinated tests - Move tests to IntrusiveOperationCluster
stevejgordon
added a commit
that referenced
this pull request
Jan 14, 2021
Implement Clone Snapshot API - Implement new API - Remove CRUD snapshot tests and replace with coordinated tests - Move tests to IntrusiveOperationCluster
stevejgordon
added a commit
that referenced
this pull request
Jan 14, 2021
Implement Clone Snapshot API (#5240) - Implement new API - Remove CRUD snapshot tests and replace with coordinated tests - Move tests to IntrusiveOperationCluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the API and refactors the snapshot tests by removing the original CRUD tests and replacing them with
CoordinatedSnapshotTests
.